Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add [NewObject] annotations to methods #746

Merged
merged 1 commit into from Jul 9, 2018
Merged

Add [NewObject] annotations to methods #746

merged 1 commit into from Jul 9, 2018

Conversation

marcoscaceres
Copy link
Member

@marcoscaceres marcoscaceres commented Jul 3, 2018 •
edited by pr-preview bot

@marcoscaceres
Copy link
Member Author

This matches Gecko's implementation, for example:
https://github.com/mozilla/gecko-dev/blob/master/dom/webidl/PaymentRequest.webidl#L97

@marcoscaceres
Copy link
Member Author

I guess this is testable... should I add them?

@marcoscaceres marcoscaceres mentioned this pull request Jul 3, 2018
Merged
5 tasks
domenic
domenic approved these changes Jul 9, 2018
View reviewed changes
Copy link
Collaborator

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never sure how I feel about these "documentation-ish" Web IDL attributes, but doesn't hurt... And it's good that it motivated some tests :)

@domenic domenic merged commit 5234bb0 into gh-pages Jul 9, 2018
@domenic domenic deleted the annotations branch July 9, 2018 20:25
aarongable pushed a commit to chromium/chromium that referenced this pull request Jul 10, 2018
@romandev
PaymentRequest: Add [NewObject] annotations to methods
e6bb68b 
Methods, like .complete(), show(), etc. always return a new object. They
should probably be marked as [NewObject].

This is no behavior change. So, no requires a "intent to implement".

Releated spec change:
  w3c/payment-request#746

Bug: none
Change-Id: Ib4646a77ab7426310c42011d69c410ef104a91a4
Reviewed-on: https://chromium-review.googlesource.com/1128825
Reviewed-by: Ganggui Tang <gogerald@chromium.org>
Commit-Queue: Jinho Bang <jinho.bang@samsung.com>
Cr-Commit-Position: refs/heads/master@{#573546}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domenic domenic domenic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[NewObject] annotation
2 participants
@marcoscaceres @domenic