[Spec] Only allow show() to be called in a foreground tab #1005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
stephenmcgruer
force-pushed
the
smcgruer/reject-if-background
branch
from
733b31c
to
406757b
Compare
stephenmcgruer
added a commit
to web-platform-tests/wpt
that referenced
this pull request
May 26, 2023
rsolomakhin
approved these changes
May 26, 2023
ianbjacobs
approved these changes
May 26, 2023
marcoscaceres
approved these changes
May 29, 2023
Co-authored-by: Marcos Cáceres <marcos@marcosc.com>
This reverts commit fe07e08.
|
Build failure appears unrelated to this change, so I'm going to merge it. |
stephenmcgruer
added a commit
to web-platform-tests/wpt
that referenced
this pull request
May 30, 2023
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Jun 13, 2023
… called in a foreground tab, a=testonly Automatic update from web-platform-tests [PaymentRequest] Only allow show() to be called in a foreground tab (#40256) See w3c/payment-request#1005 -- wpt-commits: ce9e78b850380c6bc782efeae6faaded29d0228e wpt-pr: 40256
ErichDonGubler
pushed a commit
to ErichDonGubler/firefox
that referenced
this pull request
Jun 14, 2023
… called in a foreground tab, a=testonly Automatic update from web-platform-tests [PaymentRequest] Only allow show() to be called in a foreground tab (#40256) See w3c/payment-request#1005 -- wpt-commits: ce9e78b850380c6bc782efeae6faaded29d0228e wpt-pr: 40256
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Jun 16, 2023
… called in a foreground tab, a=testonly Automatic update from web-platform-tests [PaymentRequest] Only allow show() to be called in a foreground tab (#40256) See w3c/payment-request#1005 -- wpt-commits: ce9e78b850380c6bc782efeae6faaded29d0228e wpt-pr: 40256 UltraBlame original commit: 1200c0a52171decd28e41fe24ef83c66ad347680
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Jun 16, 2023
… called in a foreground tab, a=testonly Automatic update from web-platform-tests [PaymentRequest] Only allow show() to be called in a foreground tab (#40256) See w3c/payment-request#1005 -- wpt-commits: ce9e78b850380c6bc782efeae6faaded29d0228e wpt-pr: 40256 UltraBlame original commit: 1200c0a52171decd28e41fe24ef83c66ad347680
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Jun 16, 2023
… called in a foreground tab, a=testonly Automatic update from web-platform-tests [PaymentRequest] Only allow show() to be called in a foreground tab (#40256) See w3c/payment-request#1005 -- wpt-commits: ce9e78b850380c6bc782efeae6faaded29d0228e wpt-pr: 40256 UltraBlame original commit: 1200c0a52171decd28e41fe24ef83c66ad347680
marcoscaceres
pushed a commit
that referenced
this pull request
Feb 5, 2024
This addresses this issue in SPC - https://w3c.github.io/secure-payment-confirmation/#issue-e92619e9 The behavior spec'd in SPC appears to already be followed in general Payment Request implementations already, based on testing in both Safari and Chrome, so it seems safe to just spec it here instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses this issue in SPC - https://w3c.github.io/secure-payment-confirmation/#issue-e92619e9
The behavior spec'd in SPC appears to already be followed in general Payment Request implementations already, based on testing in both Safari and Chrome, so it seems safe to just spec it here instead.
The following tasks have been completed:
Implementation commitment:
Preview | Diff