Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

l10n: adds Localizable dict + TextDirection enum #455

Closed
wants to merge 1 commit into from
Closed

l10n: adds Localizable dict + TextDirection enum #455

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1504,7 +1504,7 @@ <h2>
</h2>
<pre class="idl">
dictionary PaymentItem {
required DOMString label;
required LocalizableString label;
required PaymentCurrencyAmount amount;
boolean pending = false;
};
Expand Down Expand Up @@ -1680,7 +1680,7 @@ <h2>
<pre class="idl">
dictionary PaymentShippingOption {
required DOMString id;
required DOMString label;
required LocalizableString label;
required PaymentCurrencyAmount amount;
boolean selected = false;
};
Expand Down Expand Up @@ -2847,6 +2847,10 @@ <h2>
Web IDL
</dt>
<dd>
<p>
The <code><dfn>LocalizableString</dfn></code> <a data-cite=
"!WEBIDL-LS#dfn-typedef">typedef</a> is defined by [[!WEBIDL-LS]].
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can go ahead and just use [[WEBIDL]], btw.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will fix globally! Thanks!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[[WEBIDL]] is informative reference, [[!WEBIDL]] is normative reference.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant WEBIDL vs WEBIDL-LS, sorry if that caused confusion. :(((

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's all good. I sent #524

</p>
<p>
When this specification says to <dfn data-cite="!WEBIDL#dfn-throw"
data-lt="throws">throw</dfn> an error, the <a>user agent</a> must
Expand Down