New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Editorial: define create a PaymentAddress algo #644
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few nits that would be good to fix.
index.html
Outdated
</aside> | ||
</li> | ||
<li>Set <var>address</var>.<a>[[\country]]</a> to the user-provided | ||
<a>country</a> as an upper case [[!ISO3166]] alpha-2 code, or to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should not be <a>country</a>
as that links to a dictionary member.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch.
index.html
Outdated
</h2> | ||
<p> | ||
The steps to <dfn>create a payment address</dfn> are given by the | ||
following algorithm. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It'd be nice to mention in this sentence something like "create a payment address from user-provided input" as otherwise you get a bit taken aback realizing that this algorithm isn't a general creation algorithm, it's specifically about user input.
index.html
Outdated
provided. | ||
<ol> | ||
<li>Let <var>address</var> be the result of running the steps to | ||
<a>create a payment address</a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing a period.
Preview | Diff