Editorial: Call out payment handlers in abort() #679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per 29 Jan 2018 Payment Handler API editor discussion [1], acknowledge connection to payment handlers in abort() method. Relates to Issue #476. [1] https://www.w3.org/2018/01/29-apps-minutes#item02
|
Argh. Not sure why travis failing here. @deniak are you able to help? |
|
The travis config file was deleted as part of CR, because we are not auto-publishing. It’s safe to ignore the error. We should add a default config that just exits gracefully. |
marcoscaceres
requested changes
Jan 29, 2018
index.html
Outdated
| <li>Try to abort the current user interaction and close down any | ||
| remaining user interface. | ||
| <li>Try to abort the current user interaction with the payment | ||
| handler and close down any remaining user interface. |
There was a problem hiding this comment.
Just need <a> around payment handler.
ianbjacobs
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per 29 Jan 2018 Payment Handler API editor discussion [1], acknowledge
connection to payment handlers in abort() method.
Relates to Issue #476.
[1] https://www.w3.org/2018/01/29-apps-minutes#item02
Preview | Diff