Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editorial: align show() and canMakePayment() #682

Merged
merged 6 commits into from Apr 6, 2018
Merged

Editorial: align show() and canMakePayment() #682

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
bc0e6af
Call out payment handlers in abort()
ianbjacobs Jan 29, 2018
989c106
Merge branch 'gh-pages' of github.com:w3c/payment-request into gh-pages
ianbjacobs Jan 30, 2018
49c5ac3
https://github.com/w3c/payment-request/issues/535
ianbjacobs Feb 12, 2018
7bdb381
some tweaks based on Marcos comments
ianbjacobs Feb 20, 2018
c53f06f
another fix
ianbjacobs Feb 20, 2018
dd951a5
editorial
ianbjacobs Feb 20, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 4 additions & 4 deletions index.html
View file
Open in desktop
Expand Up @@ -3362,10 +3362,10 @@ <h2>
As part of <a>show()</a>, the user agent typically displays a list of
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: add data-link-for="PaymentRequest" to the p :)

matching <a>payment handlers</a> that satisfy the <a>payment
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's still quite unclear what "matching" is - but maybe 🤷🏽‍♂️

methods</a> accepted by the merchant and other conditions. Matching
can take into account information provided by the merchant,
information provided by the <a>payment method</a> owner, the
<a>payment handlers</a> registered by the user, user preferences, and
other considerations.
can take into account <a>payment method</a> information provided as
input to the API, information provided by the <a>payment method</a>
owner, the <a>payment handlers</a> registered by the user, user
preferences, and other considerations.
</p>
<p data-link-for="PaymentRequest">
For security reasons, a user agent can limit matching (in
Expand Down