Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

editorial: better payment handler integration #700

Merged
merged 6 commits into from May 8, 2018
Merged

editorial: better payment handler integration #700

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
eb1b1f6
editorial: better payment handler integration
marcoscaceres Apr 6, 2018
b78f372
Address @ianbjacobs feedback
marcoscaceres Apr 30, 2018
2110383
fixup ReSpec warnings
marcoscaceres Apr 30, 2018
1b5d364
review feedback
marcoscaceres May 7, 2018
a08148d
move 'steps to respond to a payment request' to dl
marcoscaceres May 7, 2018
b064909
small style fixes
marcoscaceres May 7, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions index.html
View file
Open in desktop
Expand Up @@ -166,7 +166,7 @@ <h2>
</p>
<dl>
<dt>
A <dfn>can make payment</dfn> algorithm
A <dfn>can make payment</dfn> algorithm:
</dt>
<dd>
How a payment handler determines whether it, or the user, can
Expand All @@ -176,7 +176,7 @@ <h2>
algorithm of [[payment-method-basic-card]].
</dd>
<dt>
<dfn>steps to respond to a payment request</dfn>
<dfn>Steps to respond to a payment request</dfn>:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is one an algorithm and one steps?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, what I was trying to say here is that a payment handler will need to implement or specify this (i.e., what's here is informative).

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But why is "can make payment" an algorithm and "respond to a payment request" steps?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that’s no good. Will make them consistent.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Filed bug in basic card and will fix here too. w3c/payment-method-basic-card#55

</dt>
<dd>
An algorithm that returns an object or <a data-cite=
Expand Down