Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

editorial: small non-normative bug fixes #719

Merged
merged 1 commit into from May 31, 2018
Merged

Conversation

marcoscaceres
Copy link
Member

@marcoscaceres marcoscaceres commented May 30, 2018

Editorial fixes:

  • use a set, not a list, for seenIDs (makes the language a little nicer).
  • remove redundant variables.
  • call IsWellFormedCurrencyCode() is the same way as the ES spec.
  • rename some variables, as they were ambiguous.
  • puts Abort the update into its own section.
  • Make it clear that "update a PaymentRequest's details algorithm" is running in parallel and let that algorithm control disabling the UI.
  • Fix buggy "update a PaymentRequest's details algorithm" step "In either case". Abort the update now handles state changes to request, and then can say "Abort the algorithm." Similarly, if update succeeds, then now it's just handled directly 馃憣

Preview | Diff

@marcoscaceres marcoscaceres merged commit 00a0976 into gh-pages May 31, 2018
@marcoscaceres marcoscaceres deleted the bug_fixes branch May 31, 2018 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants