Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retry request abort the update #723

Merged
merged 6 commits into from Jun 26, 2018
Merged

Retry request abort the update #723

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a73f331
Handle retry in abort the update algo
marcoscaceres Jun 11, 2018
0d9db1c
review feedback
marcoscaceres Jun 25, 2018
2660ab8
fixed note
marcoscaceres Jun 25, 2018
f1e52cc
fix dfn of [[complete]]
marcoscaceres Jun 25, 2018
c9aa022
typo
marcoscaceres Jun 25, 2018
9dffd8c
review nits
marcoscaceres Jun 26, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
20 changes: 10 additions & 10 deletions index.html
View file
Open in desktop
Expand Up @@ -4581,12 +4581,12 @@ <h2>
</section>
<div class="note">
<p>
<a data-lt="abort the update">Aborting the update</a> is performed
when there is a fatal error updating the payment request, such as
the supplied <var>detailsPromise</var> rejecting, or its
fulfillment value containing invalid data. This would potentially
leave the payment request in an inconsistent state since the
developer hasn't successfully handled the change event.
<a>Abort the update</a> runs when there is a fatal error updating
the payment request, such as the supplied <var>detailsPromise</var>
rejecting, or its fulfillment value containing invalid data. This
would potentially leave the payment request in an inconsistent
state since the developer hasn't successfully handled the change
event.
</p>
<p>
Consequently, the <a>PaymentRequest</a> moves to a "<a>closed</a>"
Expand All @@ -4595,10 +4595,10 @@ <h2>
<a data-lt="PaymentRequest.show">show()</a>.
</p>
<p data-link-for="PaymentResponse">
Similarly, aborting the update occurs during a <a>retry()</a> will
cause the <a>[[\retryPromise]]</a> to reject, and the corresponding
<a>PaymentRequest</a>'s <a>[[\complete]]</a> internal slot will be
set to true (i.e., meaning it can no longer be used).
Similarly, <a>abort the update</a> occurring during <a>retry()</a>
causes the <a>[[\retryPromise]]</a> to reject, and the
corresponding <a>PaymentRequest</a>'s <a>[[\complete]]</a> internal
slot will be set to true (i.e., it can no longer be used).
</p>
</div>
</section>
Expand Down