fix: complete() returns rejected promise #732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domenic
approved these changes
Jun 25, 2018
The current spec text read as if calling complete() twice would caused the interface to close down based on the second call. This just returns a rejected promise if the completeCalled is `true`.
marcoscaceres
force-pushed
the
fixup_complete
branch
from
0f76266
to
abbfa0c
Compare
marcoscaceres
changed the title
|
Yeah, you are right... not editorial. Adding a test. |
|
Added test web-platform-tests/wpt#11665 |
|
Argh.. linking is hard. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current spec text read as if calling complete() twice would cause
the interface to close down based on the second call.
This just returns a rejected promise if the completeCalled is
true.Preview | Diff