Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify retry() when errorFields are not passed #825

Merged
merged 3 commits into from Jan 17, 2019
Merged

Clarify retry() when errorFields are not passed #825

merged 3 commits into from Jan 17, 2019

Conversation

marcoscaceres
Copy link
Member

@marcoscaceres marcoscaceres commented Jan 16, 2019 •
edited by pr-preview bot

closes #792

The following tasks have been completed:

  • Confirmed there are no ReSpec errors/warnings.
  • Modified Web platform tests - already tested.
  • Modified MDN Docs - not required.
  • Has undergone security/privacy review - not required.

Implementation commitment:

  • Safari - already supports behavior.
  • Chrome - already supports behavior
  • Firefox - firefox supports behavior.
  • Edge (public signal)

Optional, impact on Payment Handler spec?

None.

Preview | Diff

@marcoscaceres marcoscaceres mentioned this pull request Jan 16, 2019
Closed
@rsolomakhin rsolomakhin self-requested a review January 16, 2019 15:25
ianbjacobs
ianbjacobs reviewed Jan 16, 2019
View reviewed changes
index.html Outdated Show resolved Hide resolved
ianbjacobs
ianbjacobs reviewed Jan 16, 2019
View reviewed changes
index.html Outdated Show resolved Hide resolved
ianbjacobs and others added 2 commits January 17, 2019 10:58
@ianbjacobs @marcoscaceres
Typo
e42714d 
Co-Authored-By: marcoscaceres <marcos@marcosc.com>
@ianbjacobs @marcoscaceres
Update index.html
5d75975 
Co-Authored-By: marcoscaceres <marcos@marcosc.com>
@marcoscaceres
Copy link
Member Author

Thanks for the speedy review, @rsolomakhin!

@marcoscaceres marcoscaceres merged commit 5459933 into gh-pages Jan 17, 2019
@marcoscaceres marcoscaceres deleted the retry_empty branch January 17, 2019 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ianbjacobs ianbjacobs ianbjacobs left review comments

@rsolomakhin rsolomakhin rsolomakhin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

consider requiring an error (non-empty dict) for .retry()?
3 participants
@marcoscaceres @rsolomakhin @ianbjacobs