Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PaymentRequest.prototype.hasEnrolledInstrument() #833

Merged
merged 28 commits into from
May 3, 2019
Merged
Changes from 1 commit
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
2f6bb15
Add hasEnrolledInstrument()
danyao Feb 8, 2019
78b9bb6
Add hasEnrolledInstrument() to PaymentRequest API
danyao Feb 8, 2019
bf13afe
Incorporate reviewer feedback.
ianbjacobs Feb 8, 2019
b926976
Incorporate reviewer feedback.
ianbjacobs Feb 8, 2019
ded4b4a
Incorporate reviewer feedback.
ianbjacobs Feb 8, 2019
b664b3c
Incorporate reviewer feedback.
marcoscaceres Feb 11, 2019
c408c42
Incorporate reviewer feedback.
marcoscaceres Feb 11, 2019
d38c6df
Incorporate reviewer feedback.
marcoscaceres Feb 11, 2019
a2cc4b9
reword canMakePayment note
danyao Feb 11, 2019
1f95549
Dedup canMakePayment() and hasEnrolledInstrument() algorithms
danyao Feb 11, 2019
6815ed5
Remove canMakePayment() language from Privacy Considerations because …
danyao Feb 11, 2019
7252b56
Update index.html
marcoscaceres Feb 15, 2019
c885809
Update index.html
marcoscaceres Feb 15, 2019
0f8b74c
Update index.html
marcoscaceres Feb 15, 2019
c9822c7
Update index.html
marcoscaceres Feb 15, 2019
f3f5120
Update index.html
marcoscaceres Feb 15, 2019
38174d1
Add privacy note for canMakePayment
danyao Feb 15, 2019
5d8147c
Fix early exit bug in can make payment algorithm
danyao Feb 15, 2019
7dc08ec
Update index.html
marcoscaceres Feb 15, 2019
8ad4554
Update index.html
marcoscaceres Feb 15, 2019
61260d3
Simply language per review feedback
danyao Feb 15, 2019
ca25168
Merge branch 'hasEnrolledInstrument' of https://github.com/danyao/pay…
danyao Feb 15, 2019
644ed0c
Nit: autogenerate link to section.
marcoscaceres Feb 18, 2019
25ef9c0
Update index.html
aestes Mar 4, 2019
83818dd
Merge branch 'gh-pages' into hasEnrolledInstrument
marcoscaceres Mar 22, 2019
9db2c7d
Merge with upstream/gh-pages
danyao May 2, 2019
7e28ff4
git pull origin hasEnrolledInstrument
danyao May 2, 2019
6faac81
Fix broken link
danyao May 2, 2019
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
15 changes: 7 additions & 8 deletions index.html
Original file line number Diff line number Diff line change
Expand Up @@ -5333,16 +5333,15 @@ <h2>
</section>
<section>
danyao marked this conversation as resolved.
Show resolved Hide resolved
<h2>
canMakePayment and hasEnrolledInstrument() protections
hasEnrolledInstrument() protections
danyao marked this conversation as resolved.
Show resolved Hide resolved
</h2>
<p data-link-for="PaymentRequest">
The <a>canMakePayment()</a> and <a>hasEnrolledInstrument()</a> methods
enable the payee to check if the user is ready to take advantage of
the API before calling <a>show()</a> so that it can fall back to a
legacy checkout experience if not. Because this method shares some
information with the payee, user agents are expected to protect the
user from abuse of the method, for example, by restricting the number
or frequency of calls.
The <a>hasEnrolledInstrument()</a> method enables the payee to check
danyao marked this conversation as resolved.
Show resolved Hide resolved
if the user is ready to take advantage of the API before calling
<a>show()</a> so that it can fall back to a legacy checkout experience
if not. Because this method shares some information with the payee,
user agents are expected to protect the user from abuse of the method,
for example, by restricting the number or frequency of calls.
</p>
</section>
</section>
Expand Down