Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for flushing observer via takeRecords() #74

Closed
igrigorik opened this issue Mar 17, 2017 · 0 comments
Closed

Add support for flushing observer via takeRecords() #74

igrigorik opened this issue Mar 17, 2017 · 0 comments
Labels
enhancement
Milestone
Level 2

Comments

@igrigorik
Copy link
Member

Related discussion in #66.

Use case: as a developer I want to flush and beacon all pending records when page visibility changes (e.g. transitions to 'hidden') or is about to be unloaded. Today, this is not possible.

To stay consistent with other <*>Observer patterns, we should support takeRecords():
@igrigorik igrigorik added this to the Level 3 milestone Mar 17, 2017
@igrigorik igrigorik mentioned this issue Mar 17, 2017
Closed
@igrigorik igrigorik mentioned this issue Sep 8, 2017
Merged
igrigorik added a commit that referenced this issue Oct 7, 2017
@igrigorik
define PerformanceObserver#takeRecords()
c29d569 
Closes #74.
@igrigorik igrigorik mentioned this issue Oct 7, 2017
Closed
6 tasks
@RByers RByers mentioned this issue Nov 10, 2017
Closed
igrigorik added a commit that referenced this issue Dec 8, 2017
@igrigorik
define PerformanceObserver#takeRecords()
96f6cd1 
Closes #74.
@igrigorik igrigorik mentioned this issue Dec 8, 2017
Merged
@igrigorik igrigorik modified the milestones: Level 3, Level 2 Dec 8, 2017
igrigorik added a commit that referenced this issue Jan 10, 2018
@igrigorik
define PerformanceObserver#takeRecords() (#98)
aecfdf4 
* define PerformanceObserver#takeRecords()

Closes #74.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
Level 2
Development

No branches or pull requests
1 participant
@igrigorik