Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use registry for supportedEntryTypes #133

Merged
merged 4 commits into from Jun 12, 2019

Conversation

@npm1
Copy link
Contributor

commented Jun 12, 2019

Fixes #113 and #117

Adds 'SameObject' and FrozenArray logic that is per global object.


Preview | Diff

Use registry for supportedEntryTypes
Fixes #113 and #117

Adds 'SameObject' and FrozenArray logic that is per global object.

@npm1 npm1 requested a review from yoavweiss Jun 12, 2019

index.html Outdated Show resolved Hide resolved
index.html Outdated
<li>Sort <var>result</var> in alphabetical order.</li>
<li>Return <var>result</var>.</li>
<li>Let <var>globalObject</var> be the <a href=
"https://html.spec.whatwg.org/multipage/webappapis.html#concept-settings-object-global">

This comment has been minimized.

Copy link
@yoavweiss

yoavweiss Jun 12, 2019

Contributor

You should probably use the "relevant global object of the context object" instead?

This comment has been minimized.

Copy link
@yoavweiss

yoavweiss Jun 12, 2019

Contributor

Also, you should use data-cite rather than href

This comment has been minimized.

Copy link
@npm1

npm1 Jun 12, 2019

Author Contributor

There is no context object here, supportedEntryTypes is static. Changed to data-cite.

npm1 added some commits Jun 12, 2019

@yoavweiss
Copy link
Contributor

left a comment

LGTM

@npm1 npm1 merged commit 9fcb9a4 into gh-pages Jun 12, 2019

1 check passed

ipr PR deemed acceptable.
Details

@npm1 npm1 deleted the supportedEntryTypes branch Jun 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.