Use registry for supportedEntryTypes #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yoavweiss
reviewed
Jun 12, 2019
index.html
Outdated
| <li>Sort <var>result</var> in alphabetical order.</li> | ||
| <li>Return <var>result</var>.</li> | ||
| <li>Let <var>globalObject</var> be the <a href= | ||
| "https://html.spec.whatwg.org/multipage/webappapis.html#concept-settings-object-global"> |
There was a problem hiding this comment.
You should probably use the "relevant global object of the context object" instead?
There was a problem hiding this comment.
Also, you should use data-cite rather than href
There was a problem hiding this comment.
There is no context object here, supportedEntryTypes is static. Changed to data-cite.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #113 and #117
Adds 'SameObject' and FrozenArray logic that is per global object.
Preview | Diff