Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use registry for supportedEntryTypes #133

Merged
merged 4 commits into from Jun 12, 2019
Merged

Use registry for supportedEntryTypes #133

merged 4 commits into from Jun 12, 2019

Conversation

@npm1
Copy link
Contributor

@npm1 npm1 commented Jun 12, 2019

Fixes #113 and #117

Adds 'SameObject' and FrozenArray logic that is per global object.


Preview | Diff

Fixes #113 and #117

Adds 'SameObject' and FrozenArray logic that is per global object.
@npm1 npm1 requested a review from yoavweiss Jun 12, 2019
index.html Outdated Show resolved Hide resolved
Loading
index.html Outdated
<li>Sort <var>result</var> in alphabetical order.</li>
<li>Return <var>result</var>.</li>
<li>Let <var>globalObject</var> be the <a href=
"https://html.spec.whatwg.org/multipage/webappapis.html#concept-settings-object-global">
Copy link
Contributor

@yoavweiss yoavweiss Jun 12, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should probably use the "relevant global object of the context object" instead?

Loading

Copy link
Contributor

@yoavweiss yoavweiss Jun 12, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, you should use data-cite rather than href

Loading

Copy link
Contributor Author

@npm1 npm1 Jun 12, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no context object here, supportedEntryTypes is static. Changed to data-cite.

Loading

Copy link
Contributor

@yoavweiss yoavweiss left a comment

LGTM

Loading

@npm1 npm1 merged commit 9fcb9a4 into gh-pages Jun 12, 2019
1 check passed
Loading
@npm1 npm1 deleted the supportedEntryTypes branch Jun 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants