Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dropped entries count processing logic #187

Merged
merged 3 commits into from Aug 19, 2021
Merged

Conversation

npm1
Copy link
Contributor

@npm1 npm1 commented Aug 18, 2021

Fixes #181


Preview | Diff

@npm1 npm1 requested a review from yoavweiss August 18, 2021 18:09
<li>Let <var>droppedEntriesCount</var> be 0.</li>
<li>For each <a>PerformanceObserverInit</a> <var>item</var> in
<var>registeredObserver</var>'s <a>options list</a>:
<li>Let <var>droppedEntriesCount</var> be null.</li>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why "null"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed! Null just means that we won't send that parameter.

Copy link
Contributor

@yoavweiss yoavweiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@npm1 npm1 merged commit 9d1e443 into gh-pages Aug 19, 2021
@npm1 npm1 deleted the dropped-entries-count branch August 19, 2021 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should droppedEntriesCount be frozen on each observer?
2 participants