Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some exports used elsewhere #197

Merged
merged 3 commits into from
Jan 31, 2022
Merged

Add some exports used elsewhere #197

merged 3 commits into from
Jan 31, 2022

Conversation

npm1
Copy link
Contributor

@npm1 npm1 commented Jan 27, 2022

This PR adds some export and applies some fixes for current warnings. When digging into WICG/element-timing#67, I notice that some PerformanceTimeline objects are being manually imported. But this includes some IDL objects. I suspect I shouldn't have to do this?


Preview | Diff

This PR adds some export and applies some fixes for current warnings. When digging into WICG/element-timing#67, I notice that some PerformanceTimeline objects are being manually imported. But this includes some IDL objects. I suspect I shouldn't have to do this?
@npm1
Copy link
Contributor Author

npm1 commented Jan 27, 2022

By the way, I tried removing the manual import for e.g. PerformanceEntry and it does not find the object in the Element Timing spec. I don't think we're supposed to manually export every IDL object we want to use elsewhere, but not sure what's wrong.

@marcoscaceres
Copy link
Member

I suspect I shouldn't have to do this?

Yeah, IDL definitions automatically get exported. So, feel free to remove the class="export".

By the way, I tried removing the manual import for e.g. PerformanceEntry and it does not find the object in the Element Timing spec. I don't think we're supposed to manually export every IDL object we want to use elsewhere, but not sure what's wrong.

Right. The document needs to first to end up on /TR/, and then every 6 hours.

I can see that {{PerformanceEntry}} is already in the definitions database:
https://respec.org/xref/?term=PerformanceEntry

Happy to take a look at Element Timing if it's not linking correctly.

@npm1
Copy link
Contributor Author

npm1 commented Jan 28, 2022

Thanks for confirming. I have removed the unneeded exports from the PR.

Regarding the Element Timing issue, if I remove this line[1] then bikeshed complains with

LINK ERROR: No 'idl-name' refs found for 'PerformanceEntry'.
<a class="n" data-link-type="idl-name" data-lt="PerformanceEntry">PerformanceEntry</a>

I'm not sure how to debug that. The link error seems to come from the IDL for PerformanceElementTiming.

[1] https://github.com/WICG/element-timing/blob/main/index.bs#L18

@marcoscaceres
Copy link
Member

Regarding the Element Timing issue, if I remove this line[1] then bikeshed complains with...

Yeah, that's weird... you shouldn't need <pre class=anchors> at all as specs should be exporting their definitions :(

@npm1 npm1 merged commit d1a88bf into gh-pages Jan 31, 2022
@npm1 npm1 deleted the exports branch January 31, 2022 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants