-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove PerformanceEntryFilterOptions #61
Conversation
Background: #57 (comment) Closes #60.
@toddreifsteck @plehegar PTAL. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One nit to fix otherwise LGTM.
otherwise. | ||
<a href="#filter-performance-entry-buffer-by-name-and-type"></a> | ||
algorithm with <var>name</var> set to `name` and <var>type</var> set to | ||
`null` if optional `entryType` is omitted, and <var>type</var> set to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there is no type argument for getEntriesByName. Should say:
... with name set to name
and type set to null
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
scratch that. not enough coffee it seems.
Thanks Philippe! 👍 |
Nicely done! Thanks for doing this, @plehegar and @igrigorik |
Background: #57 (comment). Closes #60.
Preview: https://cdn.rawgit.com/w3c/performance-timeline/remove-filteroptions/index.html