Add takeRecords() to PerformanceObserver #97
Conversation
index.html
Outdated
| <section> | ||
| <h2><dfn>takeRecords()</dfn> method</h2> | ||
| <p>The <a>takeRecords()</a> method returns a copy of the <a>observer | ||
| buffer</a> and empties the observer buffer.</p> |
There was a problem hiding this comment.
I think this needs to be the context object's observer buffer.
index.html
Outdated
| @@ -364,6 +365,11 @@ <h2><dfn>disconnect()</dfn> method</h2> | |||
| <a>relevant global object</a>, and also empty <a>context object</a>'s | |||
| <a>observer buffer</a>.</p> | |||
| </section> | |||
| <section> | |||
| <h2><dfn>takeRecords()</dfn> method</h2> | |||
| <p>The <a>takeRecords()</a> method returns a copy of the <a>observer | |||
There was a problem hiding this comment.
I don't think the observer buffer can be directly returned.
Can we phrase this in terms of step 4.2?
There was a problem hiding this comment.
Done. Looks almost equivalent to me
|
I created a W3C Account but after doing the confirmation I got on my email it still said it requires some sort of verification (maybe manually by someone in the group, not sure). If that happens then I can link that account to Github and the lpr check will stop failing I think |
|
Since Ilya will be back next week, makes sense to let him review. |
|
Apologies about the delay. FWIW, I have an existing WIP PR that added takeRecords: c29d569 My preference is to spell out the algorithm as in above PR. WDYT? We can break apart the above PR and land takeRecords + other editorial updates in that PR, and move #entryTypes and buffer logic into separate PR. |
|
Opened #98, let's continue there. |
@igrigorik
@spanicker
@tdresser
Preview | Diff