add accessibility considerations #412
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix #411 (minimally - this is still punting issues like actually explaining to real people what "this feature on this origin" actually means).
jyasskin
reviewed
Jan 25, 2023
| <p> | ||
| Interfaces intended to allow the user to review, update, and reset the | ||
| [=permission=] [=permission/state=] of [=powerful features=] associated with an [=origin=]. | ||
| MUST respect platform accessibility conventions. |
There was a problem hiding this comment.
Isn't this true of every UA interface? Why would permissions need special text for this? Were there specific problems with permission UI? Did browsers push back when you filed bugs about those?
There was a problem hiding this comment.
I tend to agree with @jyasskin... this is seems somewhat overly general and doesn't really add much.
I'd be inclined to add guidance around this if we had seen issues (or foresee accessibility issues!) with the UIs being presented.
So far, the UIs have been ok, no?
|
We discussed this in the Editors meeting and decided we will keep this as is. Hope that's ok @chaals. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #411 (minimally - this is still punting issues like actually explaining to real people what "this feature on this origin" actually means).
The following tasks have been completed:
Implementation commitment:
Preview | Diff