Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn PermissionSetParameters.descriptor into an object #443

Closed
saschanaz opened this issue Feb 13, 2024 · 0 comments · Fixed by #444
Closed

Turn PermissionSetParameters.descriptor into an object #443

saschanaz opened this issue Feb 13, 2024 · 0 comments · Fixed by #444

Comments

@saschanaz
Copy link
Member

saschanaz commented Feb 13, 2024

The Set Permission step 3 does: https://w3c.github.io/permissions/#webdriver-command-set-permission

  1. Let rootDesc be parameters.descriptor.

But parameters is a JS object here, so it can't just access the IDL property but should do some JS Get(), as Streams does in https://streams.spec.whatwg.org/#abstract-opdef-setupcrossrealmtransformreadable.

But an even better way to fix it is just to turn decriptor as an object, which would allow Let rootDesc be parametersDict.descriptor.

(Step 4 does the same thing for rootDesc.name when rootDesc is a JS object, maybe it can be "permission descriptor type per the result of Get(rootDesc, "name")"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant