Add name attribute to PermissionStatus

[marcoscaceres]

closes #237

Avoids having to rely on array order to know what a particular permission status belongs to.

The following tasks have been completed:

• Modified Web platform tests

Implementation commitment:

• WebKit - doesn't implement the API
• Blink - patch
• Gecko - patch

---

Preview | Diff

[marcoscaceres]

@annevk or @martinthomson, if you agree, I'm happy to add to Gecko.

@jyasskin or other Chrome folks, wdyt?

Any objection from anyone else?

[annevk]

I'm not sure I understand the motivation. A singular PermissionStatus instance is returned by query() when invoked for a particular name. It seems that in any code you might write the name is already in scope. Can you give an example where this would help?

[marcoscaceres]

Yes, sorry, see the example in #237

[annevk]

Ah, thanks! Yeah, that seems reasonable to me.

cc @johannhof

[tomayac]

It looks like the aim could be to future-proof the API for the case where one day query() could allow for multiple permissions to be queried. Right now, the recommendation is to use Promise.all() for this, which seems like a not too far off idea.

// Now
Promise.all([
  navigator.permissions.query({ name: "geolocation" }),
  navigator.permissions.query({ name: "notifications" })
])
.then(([{ state: geoState }, { state: notifState }]) => {
  console.log("Geolocation permission state is:", geoState);
  console.log("Notifications permission state is:", notifState);
});

// Potential future
const states = await navigator.permissions.query({
  name: "geolocation",
  name: "notifications",
});

[johannhof]

Yeah, I don't see a huge benefit to that alternative API but also no obvious downsides to the name attribute, so I think we'd take a patch for adding it to Gecko.

[marcoscaceres]

filed Gecko bug https://bugzilla.mozilla.org/show_bug.cgi?id=1718021 ... sent patch.

[marcoscaceres]

Filed Chromium bug: https://bugs.chromium.org/p/chromium/issues/detail?id=1236856

[jyasskin]

I think this is a good idea.

[marcoscaceres]

Ok, I'm going to go ahead and merge this as it's not particularly controversial. If no one picks it up in a few days on the Chrome side, I'll send a patch for it as it's a trivial thing to add.

[marcoscaceres]

Chrome patch: https://chromium-review.googlesource.com/c/chromium/src/+/3089276

Added a WPT via the Gecko patch (if it sticks 🤞) web-platform-tests/wpt#29999