Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce Browser Permissions for WebDriver BiDi #425

Closed
wants to merge 28 commits into from
Closed

Introduce Browser Permissions for WebDriver BiDi #425

Changes from 1 commit
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
37f9781
Introduce Browser Permissions for WebDriver BiDi
thiagowfx Nov 6, 2023
437ba0b
reorder: webdriver classic to come before bidi
thiagowfx Nov 9, 2023
d7310e3
rename browser -> permissions module
thiagowfx Nov 9, 2023
22c53fa
fix <section> nesting
thiagowfx Nov 9, 2023
49bec97
remove user context / browsing context ID for now
thiagowfx Nov 14, 2023
7c9e37b
consolidate TODOs
thiagowfx Nov 14, 2023
5ffe92c
move items around
thiagowfx Nov 14, 2023
b9fed1f
indent
thiagowfx Nov 15, 2023
acf0653
introduce and use algorithm
thiagowfx Nov 16, 2023
5e37655
s/div/ol
thiagowfx Nov 16, 2023
163fc86
s/run the set a permission/set a permission
thiagowfx Nov 16, 2023
98dd229
remove permissions.PermissionDescriptor.type
thiagowfx Nov 16, 2023
12f450b
extension -> command, add code to TODOs
thiagowfx Nov 19, 2023
afd657c
<code> -> backticks
thiagowfx Nov 21, 2023
0242b84
lang-json -> json
thiagowfx Nov 21, 2023
67e7e63
drop backticks from |rootDesc| name
thiagowfx Nov 21, 2023
b97d2fb
may -> can
thiagowfx Nov 21, 2023
4a5f3fd
same origin
thiagowfx Nov 21, 2023
edce1e0
<a>environment settings objects</a> -> [=environment settings objects=]
thiagowfx Nov 21, 2023
c6eaf4c
fix algorithm markup
thiagowfx Nov 21, 2023
5a18fe1
remove TODOs: move them to #424
thiagowfx Nov 22, 2023
175f816
algorithm: add 'and return'
thiagowfx Nov 22, 2023
a8647fe
rename all anchors to match the convention in the bidi spec
thiagowfx Nov 22, 2023
fcd4cb2
null -> `null`
thiagowfx Nov 22, 2023
edd94bc
augment algorithm paragraph with types
thiagowfx Nov 22, 2023
2f2dfb2
fix algorithm variable highlighting
thiagowfx Nov 22, 2023
4057e4a
[=environment settings object=]
thiagowfx Nov 22, 2023
0183692
[=extension command URI template|URI Template=]
thiagowfx Nov 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1282,7 +1282,7 @@ <h4 id="set-permission-command">
argument=] [=error=].
</li>
<li>
Run the [=set a permission=] algorithm, passing |typedDescriptor| and |parameters|.{{PermissionSetParameters/state}}.
[=Set a permission=] with |typedDescriptor| and |parameters|.{{PermissionSetParameters/state}}.
</li>
<li>Return <a>success</a> with data `null`.
</li>
Expand Down Expand Up @@ -1431,7 +1431,7 @@ <h6 id="extension-module-command-permissions-setPermission">
If this conversion throws an exception, return [=error=] with [=error code=] [=invalid argument=].
</li>
<li>
Run the [=set a permission=] algorithm, passing |typedDescriptor| and |state|.
[=Set a permission=] with |typedDescriptor| and |state|.
</li>
<li>
Return [=success=] with data null.
thiagowfx marked this conversation as resolved.
Show resolved Hide resolved
Expand Down