Make Permissions.request() only take a single descriptor. #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyasskin
force-pushed
the
no-request-sequence
branch
from
e9512c4
to
119deb4
Compare
|
119deb4 lgtm |
This matches the current Chromium implementation (https://code.google.com/p/chromium/codesearch/#chromium/src/third_party/WebKit/Source/modules/permissions/Permissions.idl), which has a requestAll() function to handle a sequence of permissions. A sequence could also be handled with Promise.all(), like query() suggests.
jyasskin
force-pushed
the
no-request-sequence
branch
from
119deb4
to
f8971ed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This matches the current Chromium implementation, which has a
requestAll()function to handle a sequence of permissions. A sequence could also be handled withPromise.all(), likequery()suggests.