feat(travis): autopublish with echidna (closes #24) #99
Conversation
| @@ -2,7 +2,17 @@ language: generic | |||
|
|
|||
| script: bash ./deploy.sh | |||
|
|
|||
| branches: | |||
| only: | |||
| - gh-pages | |||
There was a problem hiding this comment.
I think we want master in the only list also, or general PRs might not cause Travis to run deploy.sh to check that the files compile.
There was a problem hiding this comment.
Maybe we can get away with only having master, since deploy.sh will push to gh-pages, which causes https://w3c.github.io/permissions/ to get the new document, and then echidna will pick it up from there.
There was a problem hiding this comment.
I think we want master in the only list also, or general PRs might not cause Travis to run deploy.sh to check that the files compile.
Oh, I might be confused, but I thought we only wanted it on gh-pages to allow us to keep editing on master before deploying via gh-pages. I'll change it to master tho.
There was a problem hiding this comment.
deploy.sh automatically compiles master to gh-pages, so we don't have this intermediate step in this repository.
|
@jyasskin, made the changes you suggested. Let me know how you want to proceed. |
| - secure: SneznWMBm52ct+mFI6NAVrB8k/BjO/H/hjR1eB3tjPwF0vzpL5fnbD1mmlNmVJMTWMsSUfI917JotA+7lfwoWJuHwlq2WfzQ0ybfvtuqjo7LS22T5X8IFYmCyVNR5asbJha/LNhqUyGDsZlPBgbKK0hqTd8eWjjQTztnlSrorGM= | ||
|
|
||
| after_success: | ||
| - '[ "${TRAVIS_PULL_REQUEST}" = "false" ] && curl "https://labs.w3.org/echidna/api/request" --data "url=$URL" --data "decision=$DECISION" --data "token=$TOKEN"' |
There was a problem hiding this comment.
We could use the condition from https://github.com/w3c/permissions/blob/master/deploy.sh#L8 ([ "$TRAVIS_PULL_REQUEST" != "false" -o "$TRAVIS_BRANCH" != "master" ]) to allow Travis to run on all branches, but only ping Echidna for master commits.
LGTM either way.
|
Nobody objected to @annevk's suggestion to publish at https://lists.w3.org/Archives/Public/public-webappsec/2016Aug/0042.html, so I'm happy with this PR. Please merge when you're ready. |
Prevent TR from becoming more TRash.