Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vocab Editorial #166

Closed
riannella opened this issue May 2, 2017 · 9 comments
Closed

Vocab Editorial #166

riannella opened this issue May 2, 2017 · 9 comments
Assignees

Comments

@riannella
Copy link
Contributor

@aisaac

  • about Figure 1
    -- why does it include two ’is’ and ‘has’ arrows? These are not elements of the POE vocabulary, nor of RDFS/OWL.
    -- it’s confusing to seek to represent both sub-class and part-of relation between Rule and its specialization as one arrow.
    -- Profiles are not in the figure

  • using the word ‘concept’ for section titles like ‘Policy concepts’ or ‘Asset concepts’ doesn’t help the reader, when there are resources in the POE model that are truly of type (SKOS) Concept and are distinct from the classes and properties listed in these ‘concepts section’.

  • I think the document should present all broader/narrower relationship between SKOS concepts (e.g. Actions) in both directions. This would help readers handle sentences like in the Model’s 3.1.3 “the print Action is a subset of the use Action” (https://www.w3.org/TR/odrl-model/#conflict) that is not reflected at https://www.w3.org/TR/odrl-vocab/#term-print. I mean, the broader action of odrl:print (odrl:present) that has odrl:use as its own broader action is not even presented for odrl:print’s section.

  • “Instances of UndefinedTerm describe policies for processing unsupported actions.” (https://www.w3.org/TR/odrl-vocab/#undefinedConcepts). Is ‘policies’ the right word here?

  • in 4.1.2 and others, some sub-properties are not mentioned as possible properties (for 4.1.2, odrl:assigner and odrl:assignee; for 4.9.1, the specializations of odrl:function). According to POE’s formal semantics, it is ok to mention only odrl:relation, as done now in 4.1.2. But for helping implementers and better reflect the information model, I think it would be useful to mention the specializations (especially the specializations of abstract properties)

  • it would be better if the order of inherited properties (e.g. in 4.2.1, Agreement) would match the order in which they are given in the super-class (4.1.1, Policy)

  • why is 4.7.2 (Relation) specifically in Asset concepts? Its subjects are not instances of odrl:Asset.

  • in 4.10.1. Why is there a ‘must be supported’ in note? It’s not very informative. In fact it could apply to many other POE constructs, no? Also sometimes it’s ‘must’ and other times “MUST”.

@riannella riannella self-assigned this May 2, 2017
@riannella riannella added this to Wide/Horiz Review in ODRL Deliverables Review May 2, 2017
riannella added a commit that referenced this issue May 4, 2017
@riannella
Copy link
Contributor Author

1 - The figure has now been updated (based on the changes to the IM figure)

2 - Removed "Concepts" from section headings

3 - Updated script to also add "broader terms"

4 - Fixed

5 - Have added domain of Rule to assignee, assigner

6 - We can't change that easily (unless we start hacking http://librdf.org/raptor/rapper.html)
Suggest we leave it.

7 - True, but relation's range is Asset (in this case) Like function and Party

8 - Removed the "must be support" skos:notes. (Will be reflected in normative Vocab.)

Commited 079dbf8

@riannella riannella moved this from Wide/Horiz Review to Completed (Last Call) in ODRL Deliverables Review May 4, 2017
@riannella riannella removed this from Completed (Last Call) in ODRL Deliverables Review May 12, 2017
@simonstey
Copy link
Contributor

7 - True, but relation's range is Asset (in this case) Like function and Party

and its domain is Rule:

4.3.2 Relation
Definition: Relation is an abstract property which creates an explicit link between an Action and an Asset.
Range: Asset
Domain: Rule

so.. how?

@simonstey simonstey reopened this May 12, 2017
@riannella riannella added this to Completed (Last Call) in ODRL Deliverables Review May 15, 2017
@riannella riannella moved this from Completed (Last Call) to Wide/Horiz Review in ODRL Deliverables Review May 15, 2017
@aisaac
Copy link

aisaac commented May 18, 2017 via email

@riannella
Copy link
Contributor Author

  1. In fact it's domain is Rule and Policy.
    Listing relation in Asset is not wrong, is it?

@riannella riannella moved this from Wide/Horiz Review to Proposed Solution in ODRL Deliverables Review May 29, 2017
@aisaac
Copy link

aisaac commented May 29, 2017 via email

@riannella
Copy link
Contributor Author

ok, so:
1 - Move relation and function to Rule
2 - Move hasPolicy to Asset

ok?

@riannella
Copy link
Contributor Author

Done.

commit ac44dfa

@aisaac
Copy link

aisaac commented Jun 6, 2017 via email

@aisaac
Copy link

aisaac commented Jun 16, 2017

I was asked to check issues in which I was involved. I think this one can be closed now.

@riannella riannella removed this from Proposed Solution in ODRL Deliverables Review Jun 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants