Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Diagram missing arrows #249

Closed
vroddon opened this issue Sep 6, 2017 · 7 comments
Closed

Diagram missing arrows #249

vroddon opened this issue Sep 6, 2017 · 7 comments
Assignees
@riannella
Labels
Editorial Model
Projects
ODRL Deliverables Review

Comments

@vroddon
Copy link
Contributor

vroddon commented Sep 6, 2017

I don't think this is urgent, but I am sad to discover that the already-overloaded Figure 1 misses a couple of arrows: from Policy to Target and from Policy to Asset. Perhaps we can have two diagrams (summary / complete).
@riannella riannella added the Model label Sep 6, 2017
@riannella
Copy link
Contributor

Do you mean for these cases:
https://w3c.github.io/poe/model/#composition-compact

@riannella riannella added this to Under Current Discussion in ODRL Deliverables Review Sep 6, 2017
@vroddon
Copy link
Contributor Author

vroddon commented Sep 6, 2017

Yes... ...I guess this can wait; perhaps we can leave this issue open.

@riannella
Copy link
Contributor

What if we added this figure to section 2.7.1
test

@vroddon
Copy link
Contributor Author

vroddon commented Sep 6, 2017

Good. If we lose the completeness, in a future we can still alleviate even more the main diagram.

riannella added a commit that referenced this issue Sep 6, 2017
@riannella
Added shared properties figure #249
88dfc3b
@riannella
Copy link
Contributor

Done !

@riannella riannella moved this from Under Current Discussion to Proposed Solution in ODRL Deliverables Review Sep 6, 2017
@vroddon
Copy link
Contributor Author

vroddon commented Sep 6, 2017

One arrow may be wrong.
In Figure 1, the arrow between LogicalConstraint and Constraint is "listOf". I believe it should be "list".

@riannella
Copy link
Contributor

fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@riannella riannella

Labels
Editorial Model
Projects
ODRL Deliverables Review
Proposed Solution
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vroddon @riannella