Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorder the events in process pending pointer capture #40

Closed

Conversation

NavidZ
Copy link
Member

@NavidZ NavidZ commented Mar 8, 2016

Following #39,
move the pointerleave/out events before the gotpointercapture
and also relax the condition for sending those as the current spec
does not consider the case that the capture is transferred from a
node to another.

Move the pointerleave/out events to be before the gotpointercapture
and also relax the condition for sending those as the current spec
does not consider the case that the capture is transferred from a
node to another.
@RByers
Copy link
Contributor

RByers commented May 11, 2016

This looks good to me and seems like a logical simplification. This is still quite complicated, so I'd love to see some tests to go along with this change (but we don't necessarily need to block updating the spec).

@patrickhlauke
Copy link
Member

What was the status of this? Did we agree this was good to merge? If so, it'll need a rebase first

@NavidZ
Copy link
Member Author

NavidZ commented Jun 13, 2016

No. I believe this is one of those issues that depends on whether we send boundary events while capturing or not. Do you want me to close this for now or is it better to leave it open?

@patrickhlauke
Copy link
Member

happy to leave it open for now until we figure out the bigger picture :)

@mingchou
Copy link

About the last 'if' of the modifications, in the case that the pointer capture target override is not set and set pending pointer capture to any node other than the hit test node, shall we still fire pointerover and pointerenter to the hit test node?

@NavidZ
Copy link
Member Author

NavidZ commented Jul 28, 2016

I believe we will get rid of all boundary events line in "Process Pending Pointer Capture" section as the cleaner way of defining it would be to change the hit-testing in that case and the boundary events will follow the UI Events spec. So I need to get rid of this PR and upload another one for that proposal.

@NavidZ
Copy link
Member Author

NavidZ commented Jul 28, 2016

With Chrome going forward with change in the definition of hit-testing while a pointer is captured, I will close this PR and create another one which includes that proposal in one PR.

@NavidZ NavidZ closed this Jul 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants