Move definition point for PointerEvent #406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, references to `{{PointerEvent}}` / `<a>PointerEvent</a>` link to/land on the sentence "The PointerEventInit dictionary is used by the PointerEvent interface's constructor..." which comes *after* the WebIDL and explanation prose for all the properties/methods. https://w3c.github.io/pointerevents/#dom-pointerevent
With this change, the `<dfn>` there is removed, and as a result, references to PointerEvent now link to (thanks to Respec) to the actual WebIDL definition itself, which seems far more logical. This is in line (by the look of it) with how other specs handle this (see for instance https://www.w3.org/TR/uievents/#mouseevent which links to the WebIDL)
patrickhlauke
requested review from
flackr,
plehegar,
mustaqahmed and
smaug----
smaug----
approved these changes
Aug 5, 2021
patrickhlauke
deleted the
patrickhlauke-move-definition-point-for-pointerevents
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, references to
{{PointerEvent}}/<a>PointerEvent</a>link to/land on the sentence "The PointerEventInit dictionary is used by the PointerEvent interface's constructor..." which comes after the WebIDL and explanation prose for all the properties/methods. https://w3c.github.io/pointerevents/#dom-pointereventWith this change, the
<dfn>there is removed, and as a result, references to PointerEvent now link to (thanks to Respec) the actual WebIDL definition itself, which seems far more logical. This is in line (by the look of it) with how other specs handle this (see for instance https://www.w3.org/TR/uievents/#mouseevent which links to the WebIDL)Preview | Diff