Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make note about UAs not firing compat events if they support touch events normative #413

Merged
merged 3 commits into from Sep 30, 2021

Conversation

patrickhlauke
Copy link
Member

@patrickhlauke patrickhlauke commented Sep 13, 2021

x-ref #405


Preview | Diff

@mustaqahmed
Copy link
Member

The linked normative text in the TouchEvent spec starts with a "may", so IMHO we need to avoid normative suppression of compat events here! I suggest keeping the note as is but with a "MAY" instead.

@patrickhlauke
Copy link
Member Author

we're trying to avoid MAY, SHOULD, etc inside non-normative notes though. i missed that touch event mouse events were MAY. so, here's a thought: change this (i'll have a think how exactly) to basically say that UAs SHOULD NOT generate both and leave it at that (and leave it up to UAs to decide what to do ... or is that too wooly?)

@mustaqahmed
Copy link
Member

Sounds good. Can we somehow highlight the possibility of duplicate event firing? I think it is possible to cover both specs using a single set of compact events (even with multi-touch because we care only about the primary touch pointer here), but the "may" on the other side makes it impossible to be precise.

If the user agent supports both Touch Events and Pointer Events, the user agent SHOULD guarantee not to fire duplicate compatibility events from a single touch interaction...

@patrickhlauke
Copy link
Member Author

Updated the wording per the above (noting that touch events aren't just for touch interactions, but also cover pen/stylus nowadays)

Copy link
Member

@mustaqahmed mustaqahmed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, this looks great!

@patrickhlauke
Copy link
Member Author

discussed in meeting today: change SHOULD NOT to MUST NOT, take out last sentence ", as a result of a touch or pen interaction." as it's redundant

@patrickhlauke
Copy link
Member Author

Made the edits discussed in meeting yesterday. Merging, as otherwise we were ok with this.

@patrickhlauke patrickhlauke merged commit f23345b into gh-pages Sep 30, 2021
@patrickhlauke patrickhlauke deleted the patrickhlauke-notes-vs-normative4 branch September 30, 2021 23:21
@mustaqahmed
Copy link
Member

The WPTS in pointerevents/compat/ folder asserts the correct number of compat mouse events, whether or not the UA supports Touch Events.

@mustaqahmed mustaqahmed removed the wpt label Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants