Removed "pen contact" condition on button/buttons. #96
Conversation
To support button presses on a hovering stylus, button and buttons shouldn't require a pen contact when barrel/eraser buttons are pressed.
| @@ -364,7 +364,7 @@ | |||
| <table class="simple"> | |||
| <thead><tr><th>Current state of device buttons</th><th><code>buttons</code></th></tr></thead> | |||
| <tbody> | |||
| <tr><td><b>Mouse move with no buttons pressed</b></td><td>0</td></tr> | |||
| <tr><td><b>Mouse moved with no buttons pressed</b><br>, Pen moved without changing its <a>active buttons state</a></td><td>0</td></tr> | |||
There was a problem hiding this comment.
A quick thought: this seems more correct to replace the mouse/pen specific lines with:
"No change in active buttons state => 0"
|
LGTM (and ignore the remaining note/discussion about hovering click, as I think that's sufficiently addressed in current wording and not exactly standard anyway). |
| @@ -364,13 +364,13 @@ | |||
| <table class="simple"> | |||
| <thead><tr><th>Current state of device buttons</th><th><code>buttons</code></th></tr></thead> | |||
| <tbody> | |||
| <tr><td><b>Mouse move with no buttons pressed</b></td><td>0</td></tr> | |||
| <tr><td>Left Mouse,<br>Touch Contact,<br>Pen contact (with no modifier buttons pressed)</td><td>1</td></tr> | |||
| <tr><td><b>Mouse moved with no buttons pressed</b>,<br> Pen moved while hovering with no buttons pressed</td><td>0</td></tr> | |||
There was a problem hiding this comment.
Pen moved while hovering with no buttons pressed
Note that "moved" here includes the cases when the "footprint" of the pen is unmoved: e.g. a change in twist. I think the pen still must move physically to generate an event, so this is fine.
Do we need a note?
There was a problem hiding this comment.
I think it's fine to treat that as implied.
|
LGTM. Not seeing any other objections to the wording, let's land this for now - we can always continue to iterate. |
|
Oh except this is substantial enough that we probably need an entry in the changlog for it (just link to the PR). |
To support button presses on a hovering stylus, button and buttons shouldn't require a pen contact when barrel/eraser buttons are pressed. This change makes pen buttons independent of pen contact.
Note that contact independent button/buttons values cause subtle changes in active button state.
Closes #14.