This repository has been archived by the owner on Jan 25, 2019. It is now read-only.
fix the case where a fork of web-platform-tests can cause comments to appear on w3c/web-platform-tests issues #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… appear on w3c/web-platform-tests issues
|
Updated to return |
sideshowbarker
approved these changes
May 5, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if a user forks web-platform-tests and sets up Travis to run on that fork, the comment bot will happily comment on
w3c/web-platform-testsissues.This is what caused the w3c-bot comments in web-platform-tests/wpt#20. I opened PR-20 on my bobholt/web-platform-tests fork (which has Travis enabled), forgetting to update the webhook URL to point to my prbuildbot instance. When travis completed and fired the webhook, the prbuildbot commented on w3c/web-platform-tests PR-20 instead of mine.