-
Notifications
You must be signed in to change notification settings - Fork 31
Conversation
With Veegish Ramdani <veegish@cyberstorm.mu>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! A couple of comments
index.html
Outdated
@@ -350,8 +350,9 @@ <h2>`as` attribute</h2> | |||
</div> | |||
</section> | |||
<section> | |||
<h2>Server Push (HTTP/2)</h2> | |||
<p>HTTP/2 ([[!RFC7540]]) allows a server to pre-emptively send ("push") | |||
<h2>Server Push (HTTP/2 and HTTP/3)</h2> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better to remove the "HTTP/2" from the title
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated
index.html
Outdated
@@ -370,7 +371,7 @@ <h2>Server Push (HTTP/2)</h2> | |||
Link: </app/style.css>; rel=preload; as=style; nopush | |||
Link: </app/script.js>; rel=preload; as=script | |||
</pre> | |||
<p class="note">The above example indicates to an HTTP/2 push capable | |||
<p class="note">The above example indicates to an HTTP/2 and HTTP/3 push capable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe replace "HTTP/2 and HTTP/3 push" with "Server Push"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated
Marked as non substantive for IPR from ash-nazg. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for adding those H3 considerations! :) |
+@veegishx
Preview | Diff