Skip to content
This repository has been archived by the owner on May 5, 2022. It is now read-only.

Added http3 server push specification #150

Merged
merged 3 commits into from
Aug 20, 2020

Conversation

eznix86
Copy link
Contributor

@eznix86 eznix86 commented Jul 12, 2020

With Veegish Ramdani <veegish@cyberstorm.mu>
@eznix86 eznix86 mentioned this pull request Jul 12, 2020
Copy link
Contributor

@yoavweiss yoavweiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! A couple of comments

index.html Outdated
@@ -350,8 +350,9 @@ <h2>`as` attribute</h2>
</div>
</section>
<section>
<h2>Server Push (HTTP/2)</h2>
<p>HTTP/2 ([[!RFC7540]]) allows a server to pre-emptively send ("push")
<h2>Server Push (HTTP/2 and HTTP/3)</h2>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better to remove the "HTTP/2" from the title

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

index.html Outdated
@@ -370,7 +371,7 @@ <h2>Server Push (HTTP/2)</h2>
Link: &lt;/app/style.css&gt;; rel=preload; as=style; nopush
Link: &lt;/app/script.js&gt;; rel=preload; as=script
</pre>
<p class="note">The above example indicates to an HTTP/2 push capable
<p class="note">The above example indicates to an HTTP/2 and HTTP/3 push capable
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe replace "HTTP/2 and HTTP/3 push" with "Server Push"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

@yoavweiss
Copy link
Contributor

Marked as non substantive for IPR from ash-nazg.

Copy link
Contributor

@yoavweiss yoavweiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yoavweiss
Copy link
Contributor

Thanks for adding those H3 considerations! :)

@yoavweiss yoavweiss merged commit 890f180 into w3c:gh-pages Aug 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants