Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #39: Drop presentationId from startSession #109

Merged
merged 4 commits into from
Jun 9, 2015

Conversation

mfoltzgoogle
Copy link
Contributor

This PR implements the action from #39: drop id from startSession() without strong use case, the UA generates the id

@mfoltzgoogle
Copy link
Contributor Author

Note: I will rebase with #108 before merging.

@avayvod
Copy link
Contributor

avayvod commented Jun 9, 2015

Could you also remove the id from the default presentation link element in the example?

@mfoltzgoogle
Copy link
Contributor Author

@avayvod: Done.

mfoltzgoogle added a commit that referenced this pull request Jun 9, 2015
Issue #39: Drop presentationId from startSession
@mfoltzgoogle mfoltzgoogle merged commit d07f379 into gh-pages Jun 9, 2015
@mfoltzgoogle mfoltzgoogle deleted the drop-pid-issue-39 branch June 9, 2015 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants