Sets the state of receiving presentation connections to terminated before unload. #386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses Issue #374: Determine if we need to fire a terminated event in the receiving browsing context(s).
This changes the state of connections in the presentation to
terminatedbefore unloading the document in the receiving browsing context. This is in lieu of firing anterminateevent, which seems redundant with existing events likebeforeunload.Note that this change will prevent messages from being sent during
beforeunload, which actually seems like it should simplify implementations: they can disable and tear down the communication channels immediately upon receiving a signal to terminate.PTAL