-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix up inconsistencies in the confidentiality of FOs and Council Reports #720
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't there a problem here that the report might cite material that is confidential, and then the report cannot be less confidential than the material it cites/includes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This concept of more confidential or less confidential being on a linear scale only works if some assumptions are true. I think of it as a venn diagram where each circle is a group of people who have access. If one circle is inside another, more vs less works, but if they only partially intersect, or don't intersect at all, it doesn't work.
For example, if the Team can see Team confidential stuff, and some of the Council can see AB-confidential stuff, and some TAG-confidential stuff, then the circles are unlikely to nest nicely. It also depends on which of those groups have visibility of the FO.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dwsinger: yes, but depending on what needs saying, a report might not need to cite such confidential material, and in such cases, could be more public.
@nigelmegitt I was working off the team-only / member-visible / public confidenciality scale, which is indeed nesting. But there might be edge (or not so edge) cases where that isn't quite as neat, and I don't think it's that essential, so maybe "same level" is simpler.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's also the ambiguity that "more confidential" could mean "less visible to the same people" (e.g. redacted) or "visible to fewer people"