Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use newly introduced "initialize a sensor object" operation. #33

Merged
merged 1 commit into from
Feb 26, 2018

Conversation

riju
Copy link
Contributor

@riju riju commented Feb 26, 2018

@riju riju requested a review from anssiko February 26, 2018 16:59
Copy link
Member

@anssiko anssiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Minor nit, otherwise LGTM.

index.bs Outdated
@@ -108,8 +121,8 @@ The ProximitySensor Interface {#proximity-sensor-interface}
};
</pre>

To <dfn>Construct a ProximitySensor Object</dfn> the user agent must invoke the
<a>construct a Sensor object</a> abstract operation.
To <dfn>construct a {{ProximitySensor}} Object</dfn> the user agent must invoke the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have dropped this <dfn> from other concrete specs since it is not referenced from anywhere, so could say:

To construct a {{ProximitySensor}} object the user agent must invoke the (with lowercase object)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Done.

@anssiko anssiko merged commit 224e12f into w3c:gh-pages Feb 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants