Added names to the acknowledgements section #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
George it's hard for me to review this because it seems every section was adjusted. so, I don't just see a commented-out section unfortunately. |
|
It appears the document was reformatted to change the indenting and line lengths. Try reviewing it with the W3C diff. It ignores the whitespace changes. |
|
Did I screw something up? I open it in chrome and see a respect warning.
The commented out section seems OK.
Perhaps VS Code did some auto formatting?
It was not a lot of work to just throw it away.
Best
George
From: Matt Garrish ***@***.***>
Sent: Wednesday, December 20, 2023 1:01 PM
To: w3c/publ-a11y ***@***.***>
Cc: George ***@***.***>; Author ***@***.***>
Subject: Re: [w3c/publ-a11y] Added names to the acknowledgements section (PR #228)
It appears the document was reformatted to change the indenting and line lengths.
Try reviewing it with the W3C diff <https://services.w3.org/htmldiff?doc1=https://labs.w3.org/spec-generator/%3Ftype=respec%26url=https://w3c.github.io/publ-a11y/UX-Guide-Metadata/draft/principles/index.html&doc2=https://labs.w3.org/spec-generator/%3Ftype=respec%26url=https://cdn.statically.io/gh/w3c/publ-a11y/acknowledge/UX-Guide-Metadata/draft/principles/index.html> . It ignores the whitespace changes.
—
Reply to this email directly, view it on GitHub <#228 (comment)> , or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABW4OSC7Q23KC5VNOEIBLTDYKM7XHAVCNFSM6AAAAABA5KSH2KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNRVGA2TONRQGA> .
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
clapierre
approved these changes
Dec 20, 2023
|
I removed out the commented section in my copy and still got the respec warning. |
|
The warning is unrelated to this change. There's a link to "Example Book Features" in section 4.5.2 but the destination no longer exists. It appears to be an acknowledgement of icon use. I think section can just be deleted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am just asking Charles to review and go ahead and merge if OK. This is simple and does not need everybody to look at it. I will email the list to the mailing list to see if people want to be added or removed. I commented out the reviewers section.