Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is rendition:align-x-center allowed as a manifest meta? #1380

Closed
iherman opened this issue Oct 28, 2020 · 9 comments
Closed

Is rendition:align-x-center allowed as a manifest meta? #1380

iherman opened this issue Oct 28, 2020 · 9 comments
Labels
EPUB33 Issues addressed in the EPUB 3.3 revision Spec-EPUB3 The issue affects the core EPUB 3.3 Recommendation Topic-PackageDoc The issue affects package documents

Comments

@iherman
Copy link
Member

iherman commented Oct 28, 2020

The definition in §4.3.3.3.2 says:

The rendition:align-x-center property specifies that the given spine item should be centered horizontally in the viewport or spread.

This suggests that this property is meaningful on an item reference only. In other words:

<metadata>
    <meta property="rendition:align-x-center">true</meta>
</metadata>

or something similar is not allowed. I think that should be stated explicitly.

@mattgarrish
Copy link
Member

There's always been a question of whether anyone has implemented it. It goes beyond just where to place the spine item and requires the reading system to center the content within the page. See https://www.w3.org/dpub/IG/wiki/NakaTobira_01

We might want to consider deprecating it if it's not actually in use.

@mattgarrish
Copy link
Member

But it's not a global property, as it just doesn't make sense outside the noted use case.

@shiestyle
Copy link

Let me confirm the current status in Japan before deprecated because it was proposed from Japan, I think.

@iherman
Copy link
Member Author

iherman commented Oct 29, 2020

But it's not a global property, as it just doesn't make sense outside the noted use case.

I did not dispute that. But this is the only rendition property I found that was defined on a spite element only, and it is worth emphasizing that.

@toshiakikoike
Copy link

At the time of proposing this specification, Japanese publishers had to make trial and error of complicated description methods to realize this function.
After that, I remember that publishers did not strongly request the implementation to RS vendors because it could be realized with many RSs by the following methods.

Sample:
EPUB
https://github.com/toshiakikoike/epub_file/blob/master/mymedia.epub

Markup
https://github.com/toshiakikoike/epub_file/blob/master/mymedia/OEBPS/text/book_0001.xhtml

CSS
https://github.com/toshiakikoike/epub_file/blob/master/mymedia/OEBPS/styles/ebook_style_x.css
html {
-epub-writing-mode:horizontal-tb;
-webkit-writing-mode:horizontal-tb;
}

div.chapt {
width: auto;
height: 100%;
margin-right: auto;
margin-left: auto;
text-align:left;
-epub-writing-mode: vertical-rl;
-webkit-writing-mode: vertical-rl;
}

I have created a sample using rendition: align-x-center in the past.

https://github.com/toshiakikoike/epub-testsuite/tree/master/content/30/epub30-test-0130

I checked the implementation status of some RSs with this file.
I haven't looked at everything, but it's almost unimplemented.

Implemented
BinB Reader(by Voyager Japan,Inc. that I belong)
https://r.binb.jp/epm/e1_163698_29102020112202/?cid=Av0ndwJzdy3Dob1C&adr=291209

Not implemented
Kindle(confirmed by Previewer 3)
Kinoppy
Rakuten Kobo
Sony Reader
Google PlayBooks

@mattgarrish mattgarrish added the Topic-PackageDoc The issue affects package documents label Oct 30, 2020
@shiestyle
Copy link

As Koike-san mentioned, 'align-x-center' can be deprecated, I think.

@llemeurfr
Copy link

llemeurfr commented Nov 4, 2020

From the Readium developer community: this is not supported in Readium software.

Long time ago we've logged the issue in our Wiki. Support in EPUB files is so poor that there were conversations about how it was a mistake to have such presentation features in the OPF instead of via CSS expressions.
This is also expressed in the EPUB spec and in this thread.
-> In favor of deprecation.

@dauwhe dauwhe added the Agenda+ Issues that should be discussed during the next working group call. label Nov 11, 2020
@iherman
Copy link
Member Author

iherman commented Feb 26, 2021

The issue was discussed in a meeting on 2021-02-26

  • no resolutions were taken
View the transcript

3.1. Is rendition:align-x-center allowed as a manifest meta?

See github issue #1380.

Dave Cramer: this is about rendition:align-x-center
… the intent was that this would be used to center title pages in Japanese books
… so that everything would be in center of viewport
… issue here is that this is a bit of metadata that does not make sense as global metadata
… but the spec seems to allow it
… should we fix this by prohibiting it as global?
… there does seem to be some interest in deprecating it entirely

Garth Conboy: we (Google) don't implement it
… if you had a landscape image in fixed layout, it seems to me that there could be a use case for the global setting

Brady Duga: you said earlier that there have already been other ways to address the use case of Japanese title pages
… not sure that this is the case
… i'm currently dealing this an issue report about this right now
… the experts in Japanese rendering would currently say that there is not real CSS solution to this, but only after a great deal of specific research

Matt Garrish: its not possible for this to be a global property right now
… because there are no defined values for it currently

Dave Cramer: We do have the datapoint that a careful reader of the spec was unsure that this could be a global property
… that's some evidence that an editorial note or tweak is needed

Matt Garrish: I have no issue sticking a note in
… we can't actually have a global property, it's impossible

Dave Cramer: Let's close the issue and have a separate discussion about whether it should be deprecated
… we're potentially running into not having 2 implementations
… making this an at-risk feature

Ivan Herman: Minutes are sufficient

@mattgarrish
Copy link
Member

Closing this issue per the meeting minutes. Deprecation can be raised separately and/or we'll have to deal with this when it comes time to find implementations.

@mattgarrish mattgarrish added the EPUB33 Issues addressed in the EPUB 3.3 revision label Mar 12, 2021
@dauwhe dauwhe removed the Agenda+ Issues that should be discussed during the next working group call. label Apr 21, 2021
@mattgarrish mattgarrish added the Spec-EPUB3 The issue affects the core EPUB 3.3 Recommendation label Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
EPUB33 Issues addressed in the EPUB 3.3 revision Spec-EPUB3 The issue affects the core EPUB 3.3 Recommendation Topic-PackageDoc The issue affects package documents
Projects
None yet
Development

No branches or pull requests

6 participants