Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(I18n) Missing hreflang attribute #1488

Closed
iherman opened this issue Jan 29, 2021 · 2 comments · Fixed by #1497
Closed

(I18n) Missing hreflang attribute #1488

iherman opened this issue Jan 29, 2021 · 2 comments · Fixed by #1497
Labels
Cat-i18n Grouping label for all internationalization related issues EPUB33 Issues addressed in the EPUB 3.3 revision Spec-EPUB3 The issue affects the core EPUB 3.3 Recommendation Topic-PublicationResources The issue affects support for publications resources

Comments

@iherman
Copy link
Member

iherman commented Jan 29, 2021

The i18n self test says:

Attributes that express the language of external resources should not use the HTML lang and XML xml:lang language attributes, but should use a different attribute when they represent metadata (which indicates the intended use of the resource rather than the language of a specific range of text). more

This may be relevant for the link element. Should we add a hreflang attribute (like in HTML)?

@mattgarrish mattgarrish added the Topic-PublicationResources The issue affects support for publications resources label Jan 31, 2021
@dauwhe dauwhe added the Cat-i18n Grouping label for all internationalization related issues label Feb 3, 2021
@iherman
Copy link
Member Author

iherman commented Feb 9, 2021

The issue was discussed in a meeting on 2021-02-04

List of resolutions:

View the transcript

6. Missing hreflang attribute

See github issue #1488.

Dave Cramer: 1488
… missing hreflang attribute
see issue
… there is a PR from Matt

See github pull request #1497.

Dave Cramer: PR 1497
… this is designed for the links in the package file
… if we're linking to external metadata, we can determine the language of the file
… consistent with other vocabularies
… this would be new, and wouldn't break anything
… any comments?

Ben Schroeter: Trying to understand the usage of this?

Dave Cramer: Say you have a multi-lingual epub, multiple metadata records
… norwegian canadian dictionary that has one record in norwegian and one in canadian english
… if the UI is set in one language, it can know to present the correct metadata to the user
… the RS doesn't have to determine the vocab from the resource, it can determine before download
… a hint

Ben Schroeter: Ok

Dave Cramer: I'm not aware of a RS that does this

Brady Duga: You can link to external metadata records? /sarcasm

Dave Cramer: We can write a test for it, but no RS will test it

Ben Schroeter: And where will you find a Norwegian-Canadian dictionary...

Brady Duga: This PR does add another untestable conformance requirement

Dave Cramer: I feel we're a little bit stuck here
… it's an i18n best practice
… if we say we're going to have linked metadata, we should have this
… we put this in, we get tests, the concept gets marked as at-risk at CR
… I think we should accept the PR, then see what testing shows us

Proposed resolution: Close 1488, accept PR 1497 (Wendy Reid)

Resolution #6: Close 1488, accept PR 1497

Dave Cramer: Progress!
… on i18n issues at least
… thanks everyone

Teenya Franklin: goodnight

Dave Cramer: see you all in the comment section

Dave Cramer: RRSAgent: draft minutes

Dave Cramer: RRSAgent: bye


@mattgarrish mattgarrish added the EPUB33 Issues addressed in the EPUB 3.3 revision label Feb 15, 2021
@murata2makoto
Copy link
Contributor

I do not like the hreflang attribute. Metadata or HTTP headers for the referenced contents should specify the used language.

I know that this is not always possible. But hreflang is not a solution but a hack.

@mattgarrish mattgarrish added the Spec-EPUB3 The issue affects the core EPUB 3.3 Recommendation label Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cat-i18n Grouping label for all internationalization related issues EPUB33 Issues addressed in the EPUB 3.3 revision Spec-EPUB3 The issue affects the core EPUB 3.3 Recommendation Topic-PublicationResources The issue affects support for publications resources
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants