Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify core media types #1345

Merged
merged 4 commits into from Oct 16, 2020
Merged

Clarify core media types #1345

merged 4 commits into from Oct 16, 2020

Conversation

mattgarrish
Copy link
Member

@mattgarrish mattgarrish commented Oct 14, 2020

Picking up on #1341 (comment), this is my best attempt to expand on the perennially confusing nature of core media types.

Let me know if there's anything you don't agree with, or if any parts need further elaboration.

Feedback is always welcome beyond the reviewer list, too.


Preview | Diff

Copy link
Contributor

@TzviyaSiegman TzviyaSiegman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks clear to me. The only minor change I might suggest is s/compact/contract.

@murata2makoto
Copy link
Contributor

murata2makoto commented Oct 15, 2020

Since CSS is a core media type, I tried to check when the support of CSS is required.

Neither 2. Conformance Requirements nor
4.1.1 General Conformance mentions the support of CSS.

I am not mistaken, 4.3 CSS Style Sheets mandates the support of CSS even when the RS does not have a viewport.

@dauwhe
Copy link
Contributor

dauwhe commented Oct 15, 2020

I am not mistaken, 4.3 CSS Style Sheets mandates the support of CSS even when the RS does not have a viewport.

Section 2 covers this:

If it has a Viewport, it MUST support visual rendering of XHTML Content Documents as defined in § 4.3.1 General Conformance.

@murata2makoto
Copy link
Contributor

@dauwhe

You are right. But I think that the sentence you quoted should mention CSS.

epub33/core/index.html Outdated Show resolved Hide resolved
epub33/core/index.html Outdated Show resolved Hide resolved
epub33/core/index.html Outdated Show resolved Hide resolved
@iherman
Copy link
Member

iherman commented Oct 15, 2020

(This is not part of the changed, ie, I could not comment directly...)

The section on foreign resources say:

When a Foreign Resource is included in the spine or directly rendered in its native format in an EPUB Content Document, a fallback Core Media Type Resource MUST be included. Fallbacks take one of the two following forms:

  • intrinsic fallback mechanisms provided by the format (e.g., ability to provide more than one media type or to display an alternate embedded message when a media type cannot be rendered);

  • manifest fallbacks.

I am not sure I properly parse the first bullet items. I presume we refer to the fact that, e.g., the HTML <picture> element allows me to add several formats and let the engine choose the best. But the term "format" in that sentence seems to refer to the media element (e.g., the picture in a format that cannot be used by the RS) and not to the content document...

@mattgarrish
Copy link
Member Author

But I think that the sentence you quoted should mention CSS.

Agree, but I'll open a separate PR for this so we don't mix issues.

@mattgarrish
Copy link
Member Author

But the term "format" in that sentence seems to refer to the media element

Ya, it refers to the embedding format - SVG or XHTML or whatever the foreign resource is included in.

@mattgarrish
Copy link
Member Author

But the term "format" in that sentence seems to refer to the media element

I've changed this to:

intrinsic fallback mechanisms provided by the host format (e.g., [HTML] elements often provide ...

@iherman iherman self-requested a review October 15, 2020 11:27
@mattgarrish mattgarrish merged commit 3b7fe72 into master Oct 16, 2020
@mattgarrish mattgarrish deleted the editorial/clarify-cmt branch October 16, 2020 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants