Separate out the steps for creating a subscription #254
Conversation
index.html
Outdated
| <li>Set the <code>options</code> attribute of <var>subscription</var> to be a copy of | ||
| <var>options</var>. | ||
| </li> | ||
| <li>Generate a new P-256 <a>ECDH</a> key pair. Store the private key in an internal slot |
There was a problem hiding this comment.
Cite X9.62 on the first sentence.
There was a problem hiding this comment.
I'm not sure how to phrase this. "as described in [[!X9.62]]"?
The actual curve parameters are defined in Section 10.2, should we refer that too?
There was a problem hiding this comment.
Went with just [[!X9.62]] since "as described in" doesn't add much either.
index.html
Outdated
| <li>Generate a new P-256 <a>ECDH</a> key pair. Store the private key in an internal slot | ||
| on <var>subscription</var>; this value MUST NOT be made available to applications. The | ||
| public key is also stored in an internal slot and can be retrieved by calling the <code> | ||
| getKey</code> method of the <a>PushSubscription</a> with an argument of |
There was a problem hiding this comment.
Is this indent what tidy produces? Strange.
There was a problem hiding this comment.
Yes, presumably because the <code> block is open?
index.html
Outdated
| </li> | ||
| <li>Make a request to the <a>push service</a> to create a new <a>push subscription</a>. | ||
| Include the <a data-link-for="PushSubscriptionOptions">applicationServerKey</a> attribute | ||
| of <var>options</var> when it contains a valid point on the P-256 curve. |
There was a problem hiding this comment.
We reject the call if applicationServerKey is invalid, so you can remove the "when it contains a valid point" bit.
There was a problem hiding this comment.
"when it contains a valid point on the P-256 curve" -> "when it has been set"
index.html
Outdated
| @@ -868,9 +885,14 @@ | |||
| is one, or <code>null</code> otherwise. | |||
| </p> | |||
| <p> | |||
| When getting the <dfn>options</dfn> attribute, the <a>user agent</a> MUST return a | |||
| <code><a>PushSubscriptionOptions</a></code> object representing the options associated with | |||
There was a problem hiding this comment.
No, because PSO is the object, PSOInit is the dictionary. We return PSO.
index.html
Outdated
| @@ -930,7 +953,7 @@ | |||
| </li> | |||
| </ol> | |||
| <p> | |||
| The serializer for a <a>PushSubscription</a> invokes the following steps: | |||
| The <dfn>serializer</dfn> for a <a>PushSubscription</a> invokes the following steps: | |||
There was a problem hiding this comment.
The owning <section> has been annotated with the data-dfn-for attribute, making that redundant. That doesn't work when a section contains multiple identically named attributes, as is the case with the Init dictionaries.
beverloo
force-pushed
the
subscribe-algorithm
branch
2 times, most recently
from
880b92e
to
183b6d6
Compare
beverloo
force-pushed
the
subscribe-algorithm
branch
from
183b6d6
to
7c19dee
Compare
Fixes #235. This builds on #253, the actual changes are included in the following commit:
56fa7fc