Add generated IDL attribute names to CSS properties #611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See related discussion in: w3c/webref#51 This update adds a `styleDeclaration` property to CSS property definitions in CSS extracts. The property contains the list of IDL attribute names that the CSS property generates per the CSSOM spec on the `CSSStyleDeclaration` interface: https://drafts.csswg.org/cssom/#ref-for-css-property-to-idl-attribute The implementation of the CSS property to IDL attribute algorithm was copied over from: https://github.com/foolip/mdn-bcd-collector/blob/c2126e8f367f08333a0f7b0604e42c8fdc11d182/build.js#L569
foolip
approved these changes
May 28, 2021
There was a problem hiding this comment.
Looks good, and I grant a license to the copied code under https://github.com/w3c/reffy/blob/master/LICENSE.
src/lib/util.js
Outdated
| res.push(property); | ||
| } | ||
|
|
||
| return res.sort(); |
There was a problem hiding this comment.
It would be more convenient if the result was ordered in a predictable way, perhaps with the dashed (unmodified) attribute first, then camel-case if it's different, and finally the webkit special case if different. I'd then use the first entry for some tests.
Co-authored-by: Philip Jägenstedt <philip@foolip.org>
foolip
approved these changes
May 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See related discussion in:
w3c/webref#51
This update adds a
styleDeclarationproperty to CSS property definitions in CSS extracts. The property contains the list of IDL attribute names that the CSS property generates per the CSSOM spec on theCSSStyleDeclarationinterface:https://drafts.csswg.org/cssom/#ref-for-css-property-to-idl-attribute
The implementation of the CSS property to IDL attribute algorithm was copied over from:
https://github.com/foolip/mdn-bcd-collector/blob/c2126e8f367f08333a0f7b0604e42c8fdc11d182/build.js#L569
Note that the creation of this property is done after the crawl and not directly within the
extract-cssdfn.mjslogic because that logic only extracts CSS properties that are defined in table, and the crawler completes that list afterwards with CSS properties that are defined in prose (such as those in the compat spec).