-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make NotFoundError when prompt() is called and availability monitoring is not available optional #65
Comments
I believe this step is to handle when the user agent has disabled device discovery in a way that won't change over the lifetime of the call to |
My understanding of step 8 is that the user agent should reject immediately if it knows that the dialog will show no devices. However, the case you present is different because we need to show the dialog and do the discovery and then realize there is nothing. Is my understanding correct? |
Yes, I'm thinking about the case when the background availability monitoring is not available and we have to show the dialog to start active device discovery. We could argue that there's no timeout in this case as user could turn on a device at any moment. |
In the case you describe, |
Ok, one can argue that in the use case I describe above the UA doesn't know if the "list of available remote playback devices..." "...will remain so [empty] before the request for user permission is completed" which makes the step a no-op. |
The step 8 from the
prompt()
algorithm was inspired by the similar step (10.2) in the Presentation API'sPresentationRequest.start()
algorithm.This step seems problematic to implement when the availability monitoring is not supported by the device. At least on Android the device picker dialog will not hide until user closes it even if devices are not found. Closing the dialog by the browser would be against the current guidelines of using it I assume.
I propose making this step optional.
@mfoltzgoogle - I'm not sure how this works with the Presentation API on desktop (I think on Android it is not supported as well).
The text was updated successfully, but these errors were encountered: