Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow report types to customize the report URL #110

Merged
merged 2 commits into from
Jul 18, 2018
Merged

Allow report types to customize the report URL #110

merged 2 commits into from
Jul 18, 2018

Commits on Jul 17, 2018

  1. Allow report types to customize the report URL 

    Before, a report's URL was always the URL of the containing page (or
more accurately, of the environment settings object used to queue the
report).  For some report types, the containing page isn't relevant.
For instance, a NEL report describes a network request independent of
where or why the request was made.  A NEL report's URL should really be
the URL of the resource that was requested.

This patch allows report types to provide a custom URL if appropriate.
The document URL is a good default, though, so this customization is
optional.
    Douglas Creager committed Jul 17, 2018
    Configuration menu
    Copy the full SHA
    f3c7760 View commit details
    Browse the repository at this point in the history

  2. Remove separate report origin

    Douglas Creager committed Jul 17, 2018
    Configuration menu
    Copy the full SHA
    5bb04c4 View commit details
    Browse the repository at this point in the history