Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some respec issues #59

Merged
merged 1 commit into from
Jul 27, 2017
Merged

Fix some respec issues #59

merged 1 commit into from
Jul 27, 2017

Conversation

rmcilroy
Copy link
Contributor

@igrigorik this fixes some respec issues in the spec. It is built upon the previous pull request, and I can't find a good way in GitHub to only show the difference between this PR and the base PR, but the actual change is the "Fix some respec issues" commit in this list (rmcilroy@674d7e9)

@rmcilroy rmcilroy requested a review from igrigorik July 27, 2017 14:02
Copy link
Member

@igrigorik igrigorik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff, thanks Ross!

@igrigorik
Copy link
Member

A related but non-blocking issue that we could take up in a separate PR, before we republish this: we should update the spec reference format recommended by @marcoscaceres in w3c/preload#104 (comment).

@siusin @rmcilroy do either of you have a few cycles to tackle that? Once that's resolved, I think we're ready to ship.

@rmcilroy
Copy link
Contributor Author

Regarding the spec reference format - is it only the references to other specs (i.e., those with [Foo] which are defined to links at the bottom of index.html) which need changing here, or is there anything else?

@siusin
Copy link
Contributor

siusin commented Jul 27, 2017

@rmcilroy yes, it'd be great if you can add a Dependencies section (example) to the document to maintain the refs that are currently at the bottom.

rmcilroy added a commit to rmcilroy/requestidlecallback that referenced this pull request Aug 11, 2017
rmcilroy added a commit to rmcilroy/requestidlecallback that referenced this pull request Aug 11, 2017
rmcilroy added a commit to rmcilroy/requestidlecallback that referenced this pull request Aug 11, 2017
rmcilroy added a commit to rmcilroy/requestidlecallback that referenced this pull request Aug 11, 2017
rmcilroy added a commit to rmcilroy/requestidlecallback that referenced this pull request Sep 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants