Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Exposed to interfaces. #65

Merged
merged 3 commits into from
Sep 25, 2017
Merged

Add Exposed to interfaces. #65

merged 3 commits into from
Sep 25, 2017

Conversation

rmcilroy
Copy link
Contributor

Addresses #64

@rmcilroy
Copy link
Contributor Author

@igrigorik PTAL, thanks.

igrigorik
igrigorik reviewed Sep 22, 2017
View reviewed changes
Copy link
Member

@igrigorik igrigorik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, modulo.. missing spaces between [] and dfn?

@annevk quick sanity check, before we merge? :)

@rmcilroy
Copy link
Contributor Author

Fixed the whitespace

annevk
annevk suggested changes Sep 22, 2017
View reviewed changes
Copy link
Member

@annevk annevk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You went a little overboard. 😊 It's just interfaces that need this.

index.html Outdated
unsigned long requestIdleCallback(IdleRequestCallback callback, optional IdleRequestOptions options);
void cancelIdleCallback(unsigned long handle);
[Exposed=Window] unsigned long requestIdleCallback(IdleRequestCallback callback, optional IdleRequestOptions options);
[Exposed=Window] void cancelIdleCallback(unsigned long handle);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These two are unneeded as Window itself is already restricted.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

index.html Outdated
};

dictionary IdleRequestOptions {
[Exposed=Window] dictionary IdleRequestOptions {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not allowed (and unneeded).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@rmcilroy
Copy link
Contributor Author

Thanks, removed the unnecessary exposed attributes.

@rmcilroy
Copy link
Contributor Author

Thanks. Committing.

@rmcilroy rmcilroy closed this Sep 25, 2017
@annevk
Copy link
Member

annevk commented Sep 25, 2017

I don't see it in the commit log...

@rmcilroy rmcilroy reopened this Sep 25, 2017
@rmcilroy rmcilroy merged commit 6e9eb44 into w3c:gh-pages Sep 25, 2017
@rmcilroy
Copy link
Contributor Author

Sorry pressed the wrong button, done now.

@igrigorik
Copy link
Member

Thanks Ross!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igrigorik igrigorik igrigorik left review comments

@annevk annevk annevk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rmcilroy @annevk @igrigorik