fix: define toJSON (closes #112) #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igrigorik
approved these changes
Jun 28, 2017
There was a problem hiding this comment.
lgtm, but I'd like to get @toddreifsteck and @siusin to sanity check before we merge.
|
I've no objection to this change, but according to the group's dual spec/testing process, we should update the test case (idlharness.html) before we merge this pull request, right? I'll raise a PR to wpt later. |
|
@marcoscaceres Can you please educate me why this is change is necessary in place of serializer? |
|
@toddreifsteck they no longer exist in WebIDL. See #112. |
|
LGTM when the tests pass. |
|
For reference, IDL update for WPT: web-platform-tests/wpt#6428. |
|
web-platform-tests/wpt#6428 landed, merging this update as well. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview | Diff