Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

div that are of class "note" should have a role="note" #2045

Closed
marcoscaceres opened this issue Jan 25, 2019 · 2 comments · Fixed by #2049
Closed

div that are of class "note" should have a role="note" #2045

marcoscaceres opened this issue Jan 25, 2019 · 2 comments · Fixed by #2049
Labels
good first issue These bug should be easy for anyone getting started

Comments

@marcoscaceres
Copy link
Member

marcoscaceres commented Jan 25, 2019 •
edited

Given:

<div class="note">
  <p>I'm a note</p>
</div>

It would be great if the <div> got a role="note" attribute also attached to it.
@marcoscaceres marcoscaceres added the good first issue These bug should be easy for anyone getting started label Jan 25, 2019
@nkkumawat
Copy link
Contributor

@marcoscaceres can I try this?

@marcoscaceres
Copy link
Member Author

Sure. This one should be fairly easy too. See “issues-notes.js”.

@nkkumawat nkkumawat mentioned this issue Jan 28, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue These bug should be easy for anyone getting started
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(core/issues-notes.js): add ARIA role "note" to notes nkkumawat/respec
2 participants
@marcoscaceres @nkkumawat