Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update my name #2089

Closed
gsnedders opened this issue Feb 13, 2019 · 2 comments · Fixed by #2093
Closed

Update my name #2089

gsnedders opened this issue Feb 13, 2019 · 2 comments · Fixed by #2093

Comments

@gsnedders
Copy link

There's a few files in tests/ that refer to me as Geoffrey; these should be updated to Sam.

Given they're in tests, I don't know if there's any expectations anywhere I need to update, and I don't have the time to figure out how to run them.

The cases are:

./tests/specifications/index.html
219:        Many thanks to Marcos Cáceres for moral support, and to Bert Bos and Geoffrey Sneddon for their

./tests/specifications/ED-respec-test-20100224.html
611:        Many thanks to Marcos Cáceres for moral support, and to Bert Bos and Geoffrey Sneddon for their

./tests/specifications/snapshot-as-html_source.html
122:        Many thanks to Marcos Cáceres for moral support, and to Bert Bos and Geoffrey Sneddon for their
@marcoscaceres
Copy link
Member

No problem. Will get then fixed for ya. I don’t think anything touches those files and pretty sure nothing checks the names.

@marcoscaceres
Copy link
Member

pull request sent... will be merged soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants