Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xref: search externally first, then look for local dfn #2429

Closed
sidvishnoi opened this issue Jul 18, 2019 · 9 comments
Closed

xref: search externally first, then look for local dfn #2429

sidvishnoi opened this issue Jul 18, 2019 · 9 comments
Labels
Projects

Comments

@sidvishnoi
Copy link
Member

No description provided.

@sidvishnoi sidvishnoi added this to To do in xref via automation Jul 18, 2019
@saschanaz
Copy link
Member

Why should the xref data preferred? Is current setup causing some problems?

@marcoscaceres
Copy link
Member

I think the issue is not correctly articulated. The actual problem is that data-cite must not prevent matching local definitions.

@saschanaz
Copy link
Member

data-cite must not prevent matching local definitions.

You mean must prevent?

@marcoscaceres
Copy link
Member

marcoscaceres commented Jul 22, 2019

These must all work:

      <section>
        <p><dfn>hi there</dfn></p>
       </section>
      <section data-cite="dom html" id="test">
        <p><a id="link1">event handler</a> try either [dom] or [html]</p>
        <section data-cite="dom">
          <p data-cite="svg">
            <a id="link2">event handler</a>
            - not in [svg] -> fallback to [dom] -> fallback to [dom], [html]
              <a>hi there</a>
          </p>
          <p>
            <a id="link3" data-cite="fetch">event handler</a>
            - try and stop at [fetch] as data-cite is on self
          </p>
        </section>
      </section>

@marcoscaceres
Copy link
Member

You mean must prevent?

Nope. Must not.

@marcoscaceres
Copy link
Member

This still means match in current document first, the fall back to data-cite.

@saschanaz
Copy link
Member

saschanaz commented Jul 22, 2019

Ah okay, understood.

You mean must prevent?

Nope. Must not.

Does <a id="link3" data-cite="fetch">event handler</a> possibly fallback to local definitions? The issue title seems to say it should but I think it should not...

@marcoscaceres
Copy link
Member

Yes, but we may warn. Specs shouldn’t stomp on each other’s definitions - that’s really bad if they do.

@sidvishnoi
Copy link
Member Author

This issue was created out of confusion, so closing.

xref automation moved this from To do to Done Jul 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
xref
  
Done
Development

No branches or pull requests

3 participants